From 497da8236ab2663a8108858ba7ea59aac21c5fe6 Mon Sep 17 00:00:00 2001 From: Fam Zheng Date: Tue, 14 Aug 2018 15:25:51 +0800 Subject: luks: Allow share-rw=on MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Format drivers such as qcow2 don't allow sharing the same image between two QEMU instances in order to prevent image corruptions, because of metadata cache. LUKS driver don't modify metadata except for when creating image, so it is safe to relax the permission. This makes share-rw=on property work on virtual devices. Suggested-by: Daniel P. Berrangé Signed-off-by: Fam Zheng Reviewed-by: Daniel P. Berrangé Signed-off-by: Kevin Wolf --- block/crypto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'block/crypto.c') diff --git a/block/crypto.c b/block/crypto.c index 146d81c..33ee01b 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -627,7 +627,9 @@ BlockDriver bdrv_crypto_luks = { .bdrv_probe = block_crypto_probe_luks, .bdrv_open = block_crypto_open_luks, .bdrv_close = block_crypto_close, - .bdrv_child_perm = bdrv_format_default_perms, + /* This driver doesn't modify LUKS metadata except when creating image. + * Allow share-rw=on as a special case. */ + .bdrv_child_perm = bdrv_filter_default_perms, .bdrv_co_create = block_crypto_co_create_luks, .bdrv_co_create_opts = block_crypto_co_create_opts_luks, .bdrv_co_truncate = block_crypto_co_truncate, -- cgit v1.1