From 6b6471eee11dce4c995419b68441c6637be3d90a Mon Sep 17 00:00:00 2001 From: Bin Meng Date: Mon, 10 Oct 2022 12:04:30 +0800 Subject: block: Ignore close() failure in get_tmp_filename() The temporary file has been created and is ready for use. Checking return value of close() does not seem useful. The file descriptor is almost certainly closed; see close(2) under "Dealing with error returns from close()". Let's simply ignore close() failure here. Suggested-by: Markus Armbruster Signed-off-by: Bin Meng Reviewed-by: Markus Armbruster Message-Id: <20221010040432.3380478-1-bin.meng@windriver.com> Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'block.c') diff --git a/block.c b/block.c index 1fbf6b9..66a35b3 100644 --- a/block.c +++ b/block.c @@ -887,10 +887,7 @@ int get_tmp_filename(char *filename, int size) if (fd < 0) { return -errno; } - if (close(fd) != 0) { - unlink(filename); - return -errno; - } + close(fd); return 0; #endif } -- cgit v1.1