From fc49b77fd391fdcfc9c0b61a8c301ac0d15232e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Date: Fri, 12 Mar 2021 01:18:45 +0100 Subject: hw/timer/sse-timer: Propagate eventual error in sse_timer_realize() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If the SSECounter link is absent, we set an error message in sse_timer_realize() but forgot to propagate this error. Add the missing 'return'. Fixes: CID 1450755 (Null pointer dereferences) Signed-off-by: Philippe Mathieu-Daudé Message-id: 20210312001845.1562670-1-f4bug@amsat.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/timer/sse-timer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/timer/sse-timer.c b/hw/timer/sse-timer.c index 8dbe6ac..f959cb9 100644 --- a/hw/timer/sse-timer.c +++ b/hw/timer/sse-timer.c @@ -415,6 +415,7 @@ static void sse_timer_realize(DeviceState *dev, Error **errp) if (!s->counter) { error_setg(errp, "counter property was not set"); + return; } s->counter_notifier.notify = sse_timer_counter_callback; -- cgit v1.1