From d91d9bf617aa560082d7d5c5f405d6b70f7b42c9 Mon Sep 17 00:00:00 2001 From: Luiz Capitulino Date: Tue, 9 Jun 2009 18:21:54 -0300 Subject: monitor: Remove uneeded goto The 'found' goto in monitor_handle_command() can be dropped if we check for 'cmd->name' after looking up for the command to execute. Signed-off-by: Luiz Capitulino --- monitor.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 7620bde..fd91752 100644 --- a/monitor.c +++ b/monitor.c @@ -2432,11 +2432,13 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) /* find the command */ for(cmd = mon_cmds; cmd->name != NULL; cmd++) { if (compare_cmd(cmdname, cmd->name)) - goto found; + break; + } + + if (cmd->name == NULL) { + monitor_printf(mon, "unknown command: '%s'\n", cmdname); + return; } - monitor_printf(mon, "unknown command: '%s'\n", cmdname); - return; - found: for(i = 0; i < MAX_ARGS; i++) str_allocated[i] = NULL; -- cgit v1.1