From d765c5e5779fe25f8dcb7f65c9a27a7b5a77941f Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Tue, 10 Oct 2017 11:42:47 +0200 Subject: memory: fix off-by-one error in memory_region_notify_one() This patch fixes an off-by-one error that could lead to the notifyee to receive notifications for ranges it is not registered to. The bug has been spotted by code review. Fixes: bd2bfa4c52e5 ("memory: introduce memory_region_notify_one()") Cc: qemu-stable@nongnu.org Cc: Peter Xu Signed-off-by: Maxime Coquelin Message-Id: <20171010094247.10173-4-maxime.coquelin@redhat.com> Reviewed-by: Peter Xu Signed-off-by: Paolo Bonzini (cherry picked from commit b021d1c04452276f4926eed2d104ccbd1037a6e1) Signed-off-by: Michael Roth --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory.c b/memory.c index d908538..d05a80a 100644 --- a/memory.c +++ b/memory.c @@ -1891,7 +1891,7 @@ void memory_region_notify_one(IOMMUNotifier *notifier, * Skip the notification if the notification does not overlap * with registered range. */ - if (notifier->start > entry->iova + entry->addr_mask + 1 || + if (notifier->start > entry->iova + entry->addr_mask || notifier->end < entry->iova) { return; } -- cgit v1.1