From ba306c7a55a2fcdb51c279612f0f8fbd9a24a7ba Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 7 Dec 2015 16:55:10 +0100 Subject: sd: Mark brittle abuse of blk_attach_dev() FIXME blk_attach_dev() fails here only when we're working for device "sdhci-pci" (which already attached the backend), and then we don't want to attach a second time. If we ever create another failure mode, we're setting up ourselves to using the same backend from multiple frontends, which is likely to end in tears. Can't clean this up this close to the release, so mark it FIXME. Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell Message-id: 1449503710-3707-3-git-send-email-armbru@redhat.com Signed-off-by: Peter Maydell --- hw/sd/sd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index ce4d44b..1a9935c 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -494,6 +494,7 @@ SDState *sd_init(BlockBackend *blk, bool is_spi) if (sd->blk) { /* Attach dev if not already attached. (This call ignores an * error return code if sd->blk is already attached.) */ + /* FIXME ignoring blk_attach_dev() failure is dangerously brittle */ blk_attach_dev(sd->blk, sd); blk_set_dev_ops(sd->blk, &sd_block_ops, sd); } -- cgit v1.1