aboutsummaryrefslogtreecommitdiff
path: root/xbzrle.c
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2013-07-17 13:17:41 +0200
committerPaolo Bonzini <pbonzini@redhat.com>2013-07-18 06:03:25 +0200
commite1622f4b15391bd44eb0f99a244fdf19a20fd981 (patch)
treeaffc7b9370b3743cd856510520818f495782e58c /xbzrle.c
parent9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71 (diff)
downloadqemu-e1622f4b15391bd44eb0f99a244fdf19a20fd981.zip
qemu-e1622f4b15391bd44eb0f99a244fdf19a20fd981.tar.gz
qemu-e1622f4b15391bd44eb0f99a244fdf19a20fd981.tar.bz2
exec: fix incorrect assumptions in memory_access_size
access_size_min can be 1 because erroneous accesses must not crash QEMU, they should trigger exceptions in the guest or just return garbage (depending on the CPU). I am not sure I understand the comment: placing a 4-byte field at the last byte of a region makes no sense (unless impl.unaligned is true), and that is why memory.c:access_with_adjusted_size does not bother with minimums larger than the remaining length. access_size_max can be mr->ops->valid.max_access_size because memory.c can and will still break accesses bigger than mr->ops->impl.max_access_size. Reported-by: Markus Armbruster <armbru@redhat.com> Tested-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'xbzrle.c')
0 files changed, 0 insertions, 0 deletions