diff options
author | Daniel P. Berrangé <berrange@redhat.com> | 2020-07-21 16:17:35 +0100 |
---|---|---|
committer | Daniel P. Berrangé <berrange@redhat.com> | 2020-09-16 10:33:48 +0100 |
commit | 661b3e81a336570dfbf4c224595921d490ac792f (patch) | |
tree | a0fadd1662310688182184576326a4d63cb65580 /util/osdep.c | |
parent | c490af57cb451bf39707f4cc73650e81c5797221 (diff) | |
download | qemu-661b3e81a336570dfbf4c224595921d490ac792f.zip qemu-661b3e81a336570dfbf4c224595921d490ac792f.tar.gz qemu-661b3e81a336570dfbf4c224595921d490ac792f.tar.bz2 |
util: give a specific error message when O_DIRECT doesn't work
A common error scenario is to tell QEMU to use O_DIRECT in combination
with a filesystem that doesn't support it. To aid users to diagnosing
their mistake we want to provide a clear error message when this happens.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'util/osdep.c')
-rw-r--r-- | util/osdep.c | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/util/osdep.c b/util/osdep.c index c99f1e7..8ea7a80 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -332,11 +332,24 @@ qemu_open_internal(const char *name, int flags, mode_t mode, Error **errp) if (ret == -1) { const char *action = flags & O_CREAT ? "create" : "open"; +#ifdef O_DIRECT + /* Give more helpful error message for O_DIRECT */ + if (errno == EINVAL && (flags & O_DIRECT)) { + ret = open(name, flags & ~O_DIRECT, mode); + if (ret != -1) { + close(ret); + error_setg(errp, "Could not %s '%s': " + "filesystem does not support O_DIRECT", + action, name); + errno = EINVAL; /* restore first open()'s errno */ + return -1; + } + } +#endif /* O_DIRECT */ error_setg_errno(errp, errno, "Could not %s '%s'", action, name); } - return ret; } |