aboutsummaryrefslogtreecommitdiff
path: root/util/iov.c
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2014-02-26 23:51:46 +0000
committerMichael Tokarev <mjt@tls.msk.ru>2014-03-03 09:45:46 +0400
commitaa830cdc28edb69c1fe81c8fd9471ab288ad0926 (patch)
treefc233fab9aca88e916d0f761a469aba619250bb0 /util/iov.c
parent7edd9ddc979f112287ff5184590830c67ea991bf (diff)
downloadqemu-aa830cdc28edb69c1fe81c8fd9471ab288ad0926.zip
qemu-aa830cdc28edb69c1fe81c8fd9471ab288ad0926.tar.gz
qemu-aa830cdc28edb69c1fe81c8fd9471ab288ad0926.tar.bz2
qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration
The function qobject_from_json() doesn't actually allow its argument to be a format string -- it passes a NULL va_list* to qobject_from_jsonv(), and the parser code will then never actually interpret %-escape sequences (it tests whether the va_list pointer is NULL and will stop with a parse error). The spurious attribute markup causes clang warnings in some of the test cases where we programmatically construct JSON to feed to qobject_from_json(): tests/test-qmp-input-visitor.c:76:35: warning: format string is not a string literal (potentially insecure) [-Wformat-security] data->obj = qobject_from_json(json_string); ^~~~~~~~~~~ Remove the incorrect attribute. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Suggested-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Andreas Färber <afaerber@suse.de> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'util/iov.c')
0 files changed, 0 insertions, 0 deletions