diff options
| author | Markus Armbruster <armbru@redhat.com> | 2015-12-17 17:35:14 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2016-01-13 11:58:58 +0100 |
| commit | 543202c0ddbcc4ee97d82fe45356e1ab00093f90 (patch) | |
| tree | 44ca326a29cb61e8ae121ab390eb80e65aa50445 /util/error.c | |
| parent | 9280eb34deb032d7c86275a92651ae63cc5418d5 (diff) | |
| download | qemu-543202c0ddbcc4ee97d82fe45356e1ab00093f90.zip qemu-543202c0ddbcc4ee97d82fe45356e1ab00093f90.tar.gz qemu-543202c0ddbcc4ee97d82fe45356e1ab00093f90.tar.bz2 | |
error: Don't append a newline when printing the error hint
Since commit 50b7b00, we have error_append_hint() to conveniently
accumulate Error member @hint. error_report_err() prints it with a
newline appended. Consequently, users of error_append_hint() need to
know whether theirs is the final line of the hint to decide whether it
needs a newline. Not a nice interface.
Change error_report_err() to print just the hint, and the (still few)
users of error_append_hint() to add the required newline.
Cc: Eric Blake <eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1450370121-5768-7-git-send-email-armbru@redhat.com>
Diffstat (limited to 'util/error.c')
| -rw-r--r-- | util/error.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/error.c b/util/error.c index 80c89a2..9b27c45 100644 --- a/util/error.c +++ b/util/error.c @@ -204,7 +204,7 @@ void error_report_err(Error *err) { error_report("%s", error_get_pretty(err)); if (err->hint) { - error_printf_unless_qmp("%s\n", err->hint->str); + error_printf_unless_qmp("%s", err->hint->str); } error_free(err); } |