diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2020-05-11 19:36:30 +0100 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2020-05-18 18:16:00 +0100 |
| commit | ba607ca8bff4d2c2062902f8355657c865ac7c29 (patch) | |
| tree | de002f3ab22e267501feb4b691e51c22662b1753 /util/aio-posix.c | |
| parent | de137e44f75d9868f5b548638081850f6ac771f2 (diff) | |
| download | qemu-ba607ca8bff4d2c2062902f8355657c865ac7c29.zip qemu-ba607ca8bff4d2c2062902f8355657c865ac7c29.tar.gz qemu-ba607ca8bff4d2c2062902f8355657c865ac7c29.tar.bz2 | |
aio-posix: disable fdmon-io_uring when GSource is used
The glib event loop does not call fdmon_io_uring_wait() so fd handlers
waiting to be submitted build up in the list. There is no benefit is
using io_uring when the glib GSource is being used, so disable it
instead of implementing a more complex fix.
This fixes a memory leak where AioHandlers would build up and increasing
amounts of CPU time were spent iterating them in aio_pending(). The
symptom is that guests become slow when QEMU is built with io_uring
support.
Buglink: https://bugs.launchpad.net/qemu/+bug/1877716
Fixes: 73fd282e7b6dd4e4ea1c3bbb3d302c8db51e4ccf ("aio-posix: add io_uring fd monitoring implementation")
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Oleksandr Natalenko <oleksandr@redhat.com>
Message-id: 20200511183630.279750-3-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'util/aio-posix.c')
| -rw-r--r-- | util/aio-posix.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/util/aio-posix.c b/util/aio-posix.c index 8af334a..1b2a3af 100644 --- a/util/aio-posix.c +++ b/util/aio-posix.c @@ -682,6 +682,18 @@ void aio_context_destroy(AioContext *ctx) aio_free_deleted_handlers(ctx); } +void aio_context_use_g_source(AioContext *ctx) +{ + /* + * Disable io_uring when the glib main loop is used because it doesn't + * support mixed glib/aio_poll() usage. It relies on aio_poll() being + * called regularly so that changes to the monitored file descriptors are + * submitted, otherwise a list of pending fd handlers builds up. + */ + fdmon_io_uring_destroy(ctx); + aio_free_deleted_handlers(ctx); +} + void aio_context_set_poll_params(AioContext *ctx, int64_t max_ns, int64_t grow, int64_t shrink, Error **errp) { |