diff options
author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:56 +0200 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:53 +0200 |
commit | d5938f29fea29581725426f203a74da746ca03e7 (patch) | |
tree | 0caa694b1084f73004a8eacced417b1ef3073fcc /ui | |
parent | b58c5c2dd29db0eae0bed800ac1a311e14007cec (diff) | |
download | qemu-d5938f29fea29581725426f203a74da746ca03e7.zip qemu-d5938f29fea29581725426f203a74da746ca03e7.tar.gz qemu-d5938f29fea29581725426f203a74da746ca03e7.tar.bz2 |
Clean up inclusion of sysemu/sysemu.h
In my "build everything" tree, changing sysemu/sysemu.h triggers a
recompile of some 5400 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h).
Almost a third of its inclusions are actually superfluous. Delete
them. Downgrade two more to qapi/qapi-types-run-state.h, and move one
from char/serial.h to char/serial.c.
hw/semihosting/config.c, monitor/monitor.c, qdev-monitor.c, and
stubs/semihost.c define variables declared in sysemu/sysemu.h without
including it. The compiler is cool with that, but include it anyway.
This doesn't reduce actual use much, as it's still included into
widely included headers. The next commit will tackle that.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-27-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Diffstat (limited to 'ui')
-rw-r--r-- | ui/input-keymap.c | 1 | ||||
-rw-r--r-- | ui/input-legacy.c | 1 | ||||
-rw-r--r-- | ui/input-linux.c | 1 | ||||
-rw-r--r-- | ui/keymaps.c | 1 | ||||
-rw-r--r-- | ui/sdl2-2d.c | 1 | ||||
-rw-r--r-- | ui/sdl2-gl.c | 1 | ||||
-rw-r--r-- | ui/sdl2-input.c | 1 | ||||
-rw-r--r-- | ui/spice-display.c | 1 |
8 files changed, 0 insertions, 8 deletions
diff --git a/ui/input-keymap.c b/ui/input-keymap.c index db5ccff..c430185 100644 --- a/ui/input-keymap.c +++ b/ui/input-keymap.c @@ -1,5 +1,4 @@ #include "qemu/osdep.h" -#include "sysemu/sysemu.h" #include "keymaps.h" #include "ui/input.h" diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 549654e..9fc78a6 100644 --- a/ui/input-legacy.c +++ b/ui/input-legacy.c @@ -24,7 +24,6 @@ #include "qemu/osdep.h" #include "qapi/qapi-commands-ui.h" -#include "sysemu/sysemu.h" #include "ui/console.h" #include "keymaps.h" #include "ui/input.h" diff --git a/ui/input-linux.c b/ui/input-linux.c index e3fa799..59456fe 100644 --- a/ui/input-linux.c +++ b/ui/input-linux.c @@ -10,7 +10,6 @@ #include "qemu/main-loop.h" #include "qemu/module.h" #include "qemu/sockets.h" -#include "sysemu/sysemu.h" #include "ui/input.h" #include "qom/object_interfaces.h" #include "sysemu/iothread.h" diff --git a/ui/keymaps.c b/ui/keymaps.c index 6e8a321..4e5fca5 100644 --- a/ui/keymaps.c +++ b/ui/keymaps.c @@ -25,7 +25,6 @@ #include "qemu/osdep.h" #include "qemu-common.h" #include "keymaps.h" -#include "sysemu/sysemu.h" #include "trace.h" #include "qemu/ctype.h" #include "qemu/error-report.h" diff --git a/ui/sdl2-2d.c b/ui/sdl2-2d.c index db191aa..a2ea851 100644 --- a/ui/sdl2-2d.c +++ b/ui/sdl2-2d.c @@ -27,7 +27,6 @@ #include "ui/console.h" #include "ui/input.h" #include "ui/sdl2.h" -#include "sysemu/sysemu.h" void sdl2_2d_update(DisplayChangeListener *dcl, int x, int y, int w, int h) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index 7a37e7c..c73d273 100644 --- a/ui/sdl2-gl.c +++ b/ui/sdl2-gl.c @@ -29,7 +29,6 @@ #include "ui/console.h" #include "ui/input.h" #include "ui/sdl2.h" -#include "sysemu/sysemu.h" static void sdl2_set_scanout_mode(struct sdl2_console *scon, bool scanout) { diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c index b1daae4..1f9fe83 100644 --- a/ui/sdl2-input.c +++ b/ui/sdl2-input.c @@ -27,7 +27,6 @@ #include "ui/console.h" #include "ui/input.h" #include "ui/sdl2.h" -#include "sysemu/sysemu.h" void sdl2_process_key(struct sdl2_console *scon, SDL_KeyboardEvent *ev) diff --git a/ui/spice-display.c b/ui/spice-display.c index 0c65ae2..6babe24 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -22,7 +22,6 @@ #include "qemu/option.h" #include "qemu/queue.h" #include "ui/console.h" -#include "sysemu/sysemu.h" #include "trace.h" #include "ui/spice-display.h" |