diff options
| author | Daniel P. Berrange <berrange@redhat.com> | 2017-12-18 19:12:28 +0000 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2018-01-12 13:48:54 +0100 |
| commit | 30b80fd5269257f55203b7072c505b4ebaab5115 (patch) | |
| tree | d8fc1287d1ec86bd3910ccbc6120f8444b870393 /ui/vnc-auth-sasl.h | |
| parent | 6aa22a29187e1908f5db738d27c64a9efc8d0bfa (diff) | |
| download | qemu-30b80fd5269257f55203b7072c505b4ebaab5115.zip qemu-30b80fd5269257f55203b7072c505b4ebaab5115.tar.gz qemu-30b80fd5269257f55203b7072c505b4ebaab5115.tar.bz2 | |
ui: mix misleading comments & return types of VNC I/O helper methods
While the QIOChannel APIs for reading/writing data return ssize_t, with negative
value indicating an error, the VNC code passes this return value through the
vnc_client_io_error() method. This detects the error condition, disconnects the
client and returns 0 to indicate error. Thus all the VNC helper methods should
return size_t (unsigned), and misleading comments which refer to the possibility
of negative return values need fixing.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-14-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'ui/vnc-auth-sasl.h')
| -rw-r--r-- | ui/vnc-auth-sasl.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ui/vnc-auth-sasl.h b/ui/vnc-auth-sasl.h index b9d8de1..2ae224e 100644 --- a/ui/vnc-auth-sasl.h +++ b/ui/vnc-auth-sasl.h @@ -65,8 +65,8 @@ struct VncDisplaySASL { void vnc_sasl_client_cleanup(VncState *vs); -long vnc_client_read_sasl(VncState *vs); -long vnc_client_write_sasl(VncState *vs); +size_t vnc_client_read_sasl(VncState *vs); +size_t vnc_client_write_sasl(VncState *vs); void start_auth_sasl(VncState *vs); |