aboutsummaryrefslogtreecommitdiff
path: root/trace
diff options
context:
space:
mode:
authorDavid Hildenbrand <david@redhat.com>2017-05-31 21:34:34 +0200
committerChristian Borntraeger <borntraeger@de.ibm.com>2017-06-06 10:50:40 +0200
commitfbe8202ea81519a42855830059ccc8e10b58dfa5 (patch)
tree397c58a6fa7dad9af53f80b68f94898e88f407c1 /trace
parent64bc98f4b97d4757b4ca42ccfc27397e09302fbd (diff)
downloadqemu-fbe8202ea81519a42855830059ccc8e10b58dfa5.zip
qemu-fbe8202ea81519a42855830059ccc8e10b58dfa5.tar.gz
qemu-fbe8202ea81519a42855830059ccc8e10b58dfa5.tar.bz2
s390x/cpumodel: improve defintion search without an IBC
Currently, under z/VM on a 0x2827, QEMU will detect a 0x2828 if no IBC value is provided. QEMU will simply take the last model of that HW generation, which happens to be the BC version. Let's improve our search for that case by selecting the latest CPU definition that matches the CPU type. This for example will avoid detecting an z13 as a z13s. We might still detect a GA2 version on a GA1 system, but as we don't have further information at hand, there isn't too much we can do about it. The alternative of always presenting the oldest GA is not backward compatible, e.g: You're running on 0x2827 GA2. Old QEMU version indicated "0x2828 GA1 == 0x2827 GA2". After you updated QEMU, you suddenly detect "0x2827 GA1". You're previous libvirt guest might suddenly refuse to run. In the end presenting a newer GA level does not matter because: 1: All GAX models share the same base feature set. A GAX++ might support "more features". 2: Without an IBC, the guest can't detect the GA version. If we have no IBC (esp. unblocked_ibc == 0), the IBC we will present to the guest in read_SCP_info() will be 0. The guest will not know which GA version it has. The problem of missing IBC propagates. If we don't have a feature of the GA++ version, also our guest won't have it. So in summary, the guest also has no idea of its GA version. Signed-off-by: David Hildenbrand <david@redhat.com> Message-Id: <20170531193434.6918-3-david@redhat.com> Acked-by: Jason J. Herne <jjherne@linux.vnet.ibm.com> Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> [improve patch description by reusing mailing list discussion]
Diffstat (limited to 'trace')
0 files changed, 0 insertions, 0 deletions