diff options
| author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2020-11-02 10:23:39 +0100 |
|---|---|---|
| committer | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2020-11-02 18:32:41 +0000 |
| commit | 2693026042d2f6f5749babb8827b8098ed5d7eb4 (patch) | |
| tree | 313e646f8dc42b310d008df8e2f2f7ad58e1bd07 /tools/virtiofsd | |
| parent | dcaac9f124833e62e720d0733aa53453f438b7d7 (diff) | |
| download | qemu-2693026042d2f6f5749babb8827b8098ed5d7eb4.zip qemu-2693026042d2f6f5749babb8827b8098ed5d7eb4.tar.gz qemu-2693026042d2f6f5749babb8827b8098ed5d7eb4.tar.bz2 | |
tools/virtiofsd: Check vu_init() return value (CID 1435958)
Since commit 6f5fd837889, vu_init() can fail if malloc() returns NULL.
This fixes the following Coverity warning:
CID 1435958 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Fixes: 6f5fd837889 ("libvhost-user: support many virtqueues")
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201102092339.2034297-1-philmd@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'tools/virtiofsd')
| -rw-r--r-- | tools/virtiofsd/fuse_virtio.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 3249369..83ba07c 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -1013,8 +1013,11 @@ int virtio_session_mount(struct fuse_session *se) se->vu_socketfd = data_sock; se->virtio_dev->se = se; pthread_rwlock_init(&se->virtio_dev->vu_dispatch_rwlock, NULL); - vu_init(&se->virtio_dev->dev, 2, se->vu_socketfd, fv_panic, NULL, - fv_set_watch, fv_remove_watch, &fv_iface); + if (!vu_init(&se->virtio_dev->dev, 2, se->vu_socketfd, fv_panic, NULL, + fv_set_watch, fv_remove_watch, &fv_iface)) { + fuse_log(FUSE_LOG_ERR, "%s: vu_init failed\n", __func__); + return -1; + } return 0; } |