diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2023-05-25 14:47:04 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-05-30 17:21:23 +0200 |
| commit | c6e0a6de62c5fa99ef06a9bb49c8072bcf93f431 (patch) | |
| tree | f5d9f4d7fa1c9df9acc4906f84a7676ffa122e3e /tests | |
| parent | ae400dbb8f439021bca5b8a7f60907bbd2cf5291 (diff) | |
| download | qemu-c6e0a6de62c5fa99ef06a9bb49c8072bcf93f431.zip qemu-c6e0a6de62c5fa99ef06a9bb49c8072bcf93f431.tar.gz qemu-c6e0a6de62c5fa99ef06a9bb49c8072bcf93f431.tar.bz2 | |
block: Take main AioContext lock when calling bdrv_open()
The function documentation already says that all callers must hold the
main AioContext lock, but not all of them do. This can cause assertion
failures when functions called by bdrv_open() try to drop the lock. Fix
a few more callers to take the lock before calling bdrv_open().
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230525124713.401149-4-kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/unit/test-block-iothread.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tests/unit/test-block-iothread.c b/tests/unit/test-block-iothread.c index 3a5e1eb..1b40e65 100644 --- a/tests/unit/test-block-iothread.c +++ b/tests/unit/test-block-iothread.c @@ -833,8 +833,11 @@ static void test_attach_second_node(void) qdict_put_str(options, "driver", "raw"); qdict_put_str(options, "file", "base"); + /* FIXME raw_open() should take ctx's lock internally */ aio_context_acquire(ctx); + aio_context_acquire(main_ctx); filter = bdrv_open(NULL, NULL, options, BDRV_O_RDWR, &error_abort); + aio_context_release(main_ctx); aio_context_release(ctx); g_assert(blk_get_aio_context(blk) == ctx); |