aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorFabiano Rosas <farosas@suse.de>2023-10-18 16:27:34 -0300
committerJuan Quintela <quintela@redhat.com>2023-10-20 08:51:41 +0200
commita3c0ebc9b09cb15cac35690412eb66aaa5eb4f23 (patch)
tree108940ee37d3b0f9961bf9c3515b0f75c3bb15d6 /tests
parent1027fc0ae4fcd24c11a43d1f217a1d11579a574b (diff)
downloadqemu-a3c0ebc9b09cb15cac35690412eb66aaa5eb4f23.zip
qemu-a3c0ebc9b09cb15cac35690412eb66aaa5eb4f23.tar.gz
qemu-a3c0ebc9b09cb15cac35690412eb66aaa5eb4f23.tar.bz2
tests/qtest: Introduce qtest_resolve_machine_alias
The migration tests are being enhanced to test migration between different QEMU versions. A requirement of migration is that the machine type between source and destination matches, including the version. We cannot hardcode machine types in the tests because those change with each release. QEMU provides a machine type alias that has a fixed name, but points to the latest machine type at each release. Add a helper to resolve the alias into the exact machine type. E.g. "-machine pc" resolves to "pc-i440fx-8.2" Reviewed-by: Juan Quintela <quintela@redhat.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Fabiano Rosas <farosas@suse.de> Signed-off-by: Juan Quintela <quintela@redhat.com> Message-ID: <20231018192741.25885-6-farosas@suse.de>
Diffstat (limited to 'tests')
-rw-r--r--tests/qtest/libqtest.c16
-rw-r--r--tests/qtest/libqtest.h10
2 files changed, 26 insertions, 0 deletions
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 603d900..c843c41 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -1565,6 +1565,22 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine),
}
}
+char *qtest_resolve_machine_alias(const char *var, const char *alias)
+{
+ struct MachInfo *machines;
+ int i;
+
+ machines = qtest_get_machines(var);
+
+ for (i = 0; machines[i].name != NULL; i++) {
+ if (machines[i].alias && g_str_equal(alias, machines[i].alias)) {
+ return g_strdup(machines[i].name);
+ }
+ }
+
+ return NULL;
+}
+
bool qtest_has_machine_with_env(const char *var, const char *machine)
{
struct MachInfo *machines;
diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h
index d16deb9..6e3d352 100644
--- a/tests/qtest/libqtest.h
+++ b/tests/qtest/libqtest.h
@@ -923,6 +923,16 @@ void qtest_cb_for_every_machine(void (*cb)(const char *machine),
bool skip_old_versioned);
/**
+ * qtest_resolve_machine_alias:
+ * @var: Environment variable from where to take the QEMU binary
+ * @alias: The alias to resolve
+ *
+ * Returns: the machine type corresponding to the alias if any,
+ * otherwise NULL.
+ */
+char *qtest_resolve_machine_alias(const char *var, const char *alias);
+
+/**
* qtest_has_machine:
* @machine: The machine to look for
*