diff options
| author | John Snow <jsnow@redhat.com> | 2020-10-06 19:58:07 -0400 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2020-10-20 09:37:57 -0400 |
| commit | 090744d552e18e600bf6d3c896a52d4846aa3e53 (patch) | |
| tree | 3a2251c8054dea9d34dd051d9bb95ced53b0b9cf /tests | |
| parent | aad3f3bb6c8b63b33db30911748fe32928b7b4bd (diff) | |
| download | qemu-090744d552e18e600bf6d3c896a52d4846aa3e53.zip qemu-090744d552e18e600bf6d3c896a52d4846aa3e53.tar.gz qemu-090744d552e18e600bf6d3c896a52d4846aa3e53.tar.bz2 | |
iotests.py: Adjust HMP kwargs typing
mypy wants to ensure there's consistency between the kwargs arguments
types and any unspecified keyword arguments. In this case, conv_keys is
a bool, but the remaining keys are Any type. Mypy (correctly) infers the
**kwargs type to be **Dict[str, str], which is not compatible with
conv_keys: bool.
Because QMP typing is a little fraught right now anyway, re-type kwargs
to Dict[str, Any] which has the benefit of silencing this check right
now.
A future re-design might type these more aggressively, but this will
give us a baseline to work from with minimal disruption.
(Thanks Kevin Wolf for the debugging assist here)
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 20201006235817.3280413-11-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/qemu-iotests/iotests.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index f212cec..63d2ace 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -605,7 +605,7 @@ class VM(qtest.QEMUQtestMachine): def hmp(self, command_line: str, use_log: bool = False) -> QMPMessage: cmd = 'human-monitor-command' - kwargs = {'command-line': command_line} + kwargs: Dict[str, Any] = {'command-line': command_line} if use_log: return self.qmp_log(cmd, **kwargs) else: |