aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorMax Reitz <mreitz@redhat.com>2019-11-08 13:34:51 +0100
committerMichael Roth <mdroth@linux.vnet.ibm.com>2020-06-22 12:38:31 -0500
commit0972fbf353e436088bbc4180bc13e93245cd7add (patch)
treed8407f320785dae42719a88171892733e25285c2 /tests
parent9b59fdf47822acb6f2f6be5629829f27ffb08d41 (diff)
downloadqemu-0972fbf353e436088bbc4180bc13e93245cd7add.zip
qemu-0972fbf353e436088bbc4180bc13e93245cd7add.tar.gz
qemu-0972fbf353e436088bbc4180bc13e93245cd7add.tar.bz2
block: Add bdrv_qapi_perm_to_blk_perm()
We need some way to correlate QAPI BlockPermission values with BLK_PERM_* flags. We could: (1) have the same order in the QAPI definition as the the BLK_PERM_* flags are in LSb-first order. However, then there is no guarantee that they actually match (e.g. when someone modifies the QAPI schema without thinking of the BLK_PERM_* definitions). We could add static assertions, but these would break what’s good about this solution, namely its simplicity. (2) define the BLK_PERM_* flags based on the BlockPermission values. But this way whenever someone were to modify the QAPI order (perfectly sensible in theory), the BLK_PERM_* values would change. Because these values are used for file locking, this might break file locking between different qemu versions. Therefore, go the slightly more cumbersome way: Add a function to translate from the QAPI constants to the BLK_PERM_* flags. Signed-off-by: Max Reitz <mreitz@redhat.com> Message-id: 20191108123455.39445-2-mreitz@redhat.com Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Signed-off-by: Max Reitz <mreitz@redhat.com> (cherry picked from commit 7b1d9c4df0603fbc526226a9c5ef91118aa6c957) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions