diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2021-05-06 20:43:58 +0100 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2021-05-14 12:28:01 +0200 |
| commit | 423dbce5a2bf392bf9f6ab655a672d3d6654c325 (patch) | |
| tree | 84dbd212d81b2fd5960685d2e690c03b34f887ca /tests | |
| parent | e0c5a18efc56fcb3b480507d8f04fb4eb9cda92f (diff) | |
| download | qemu-423dbce5a2bf392bf9f6ab655a672d3d6654c325.zip qemu-423dbce5a2bf392bf9f6ab655a672d3d6654c325.tar.gz qemu-423dbce5a2bf392bf9f6ab655a672d3d6654c325.tar.bz2 | |
tests/qtest/ahci-test.c: Calculate iso_size with 64-bit arithmetic
Coverity notes that when calculating the 64-bit iso_size value in
ahci_test_cdrom() we actually only do it with 32-bit arithmetic.
This doesn't matter for the current test code because nsectors is
always small; but adding the cast avoids the coverity complaints.
Fixes: Coverity CID 1432343
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-Id: <20210506194358.3925-1-peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/qtest/ahci-test.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/qtest/ahci-test.c b/tests/qtest/ahci-test.c index 5e19548..8073ccc 100644 --- a/tests/qtest/ahci-test.c +++ b/tests/qtest/ahci-test.c @@ -1491,14 +1491,14 @@ static void ahci_test_cdrom(int nsectors, bool dma, uint8_t cmd, char *iso; int fd; AHCIOpts opts = { - .size = (ATAPI_SECTOR_SIZE * nsectors), + .size = ((uint64_t)ATAPI_SECTOR_SIZE * nsectors), .atapi = true, .atapi_dma = dma, .post_cb = ahci_cb_cmp_buff, .set_bcl = override_bcl, .bcl = bcl, }; - uint64_t iso_size = ATAPI_SECTOR_SIZE * (nsectors + 1); + uint64_t iso_size = (uint64_t)ATAPI_SECTOR_SIZE * (nsectors + 1); /* Prepare ISO and fill 'tx' buffer */ fd = prepare_iso(iso_size, &tx, &iso); |