diff options
| author | Markus Armbruster <armbru@redhat.com> | 2022-11-04 17:06:47 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2022-12-13 18:31:37 +0100 |
| commit | 4b2fc7dbc4203c52b7726249328fcde49626f565 (patch) | |
| tree | ec71ce6387f225a02164d68a74a2c01856709b17 /tests/unit/test-visitor-serialization.c | |
| parent | 44ea9d9be33c8a4cf89132e0dc2b3029733bcaf4 (diff) | |
| download | qemu-4b2fc7dbc4203c52b7726249328fcde49626f565.zip qemu-4b2fc7dbc4203c52b7726249328fcde49626f565.tar.gz qemu-4b2fc7dbc4203c52b7726249328fcde49626f565.tar.bz2 | |
qapi tests: Elide redundant has_FOO in generated C
The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with. Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step. This is the step for
tests/qapi-schema/qapi-schema-test.json.
Said commit explains the transformation in more detail. The invariant
violations mentioned there do not occur here.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20221104160712.3005652-6-armbru@redhat.com>
Diffstat (limited to 'tests/unit/test-visitor-serialization.c')
| -rw-r--r-- | tests/unit/test-visitor-serialization.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tests/unit/test-visitor-serialization.c b/tests/unit/test-visitor-serialization.c index 667e8fe..c2056c3 100644 --- a/tests/unit/test-visitor-serialization.c +++ b/tests/unit/test-visitor-serialization.c @@ -223,7 +223,6 @@ static UserDefTwo *nested_struct_create(void) udnp->dict1->dict2->userdef->string = strdup("test_string"); udnp->dict1->dict2->string = strdup("test_string2"); udnp->dict1->dict3 = g_malloc0(sizeof(*udnp->dict1->dict3)); - udnp->dict1->has_dict3 = true; udnp->dict1->dict3->userdef = g_new0(UserDefOne, 1); udnp->dict1->dict3->userdef->integer = 43; udnp->dict1->dict3->userdef->string = strdup("test_string"); @@ -243,7 +242,7 @@ static void nested_struct_compare(UserDefTwo *udnp1, UserDefTwo *udnp2) udnp2->dict1->dict2->userdef->string); g_assert_cmpstr(udnp1->dict1->dict2->string, ==, udnp2->dict1->dict2->string); - g_assert(udnp1->dict1->has_dict3 == udnp2->dict1->has_dict3); + g_assert(!udnp1->dict1->dict3 == !udnp2->dict1->dict3); g_assert_cmpint(udnp1->dict1->dict3->userdef->integer, ==, udnp2->dict1->dict3->userdef->integer); g_assert_cmpstr(udnp1->dict1->dict3->userdef->string, ==, |