diff options
| author | Eric Blake <eblake@redhat.com> | 2015-11-05 23:35:33 -0700 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2015-11-10 08:09:14 +0100 |
| commit | dd5ee2c2d3e3a17647ddd9bfa97935b8cb5dfa40 (patch) | |
| tree | 47a7ce33ddab68e87a50e6b4496ae1a6db0beeec /tests/test-qmp-input-visitor.c | |
| parent | 12fafd7cedad51854c468ea0496a6542b3222b29 (diff) | |
| download | qemu-dd5ee2c2d3e3a17647ddd9bfa97935b8cb5dfa40.zip qemu-dd5ee2c2d3e3a17647ddd9bfa97935b8cb5dfa40.tar.gz qemu-dd5ee2c2d3e3a17647ddd9bfa97935b8cb5dfa40.tar.bz2 | |
qapi: Test failure in middle of array parse
Our generated list visitors have the same problem as has been
mentioned elsewhere (see commit 2f52e20): they allocate data
even on failure. An upcoming patch will correct things to
provide saner guarantees, but first we need to expose the
behavior in the testsuite to ensure we aren't introducing any
memory usage bugs.
There are more test cases throughout the test-qmp-input-* tests
that already deal with partial allocation; a later commit will
clean up all visit_type_FOO(), without marking all of the tests
with FIXME at this time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1446791754-23823-10-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'tests/test-qmp-input-visitor.c')
| -rw-r--r-- | tests/test-qmp-input-visitor.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/tests/test-qmp-input-visitor.c b/tests/test-qmp-input-visitor.c index ef5284d..aa02eec 100644 --- a/tests/test-qmp-input-visitor.c +++ b/tests/test-qmp-input-visitor.c @@ -698,8 +698,10 @@ static void test_visitor_in_errors(TestInputVisitorData *data, TestStruct *p = NULL; Error *err = NULL; Visitor *v; + strList *q = NULL; - v = visitor_input_test_init(data, "{ 'integer': false, 'boolean': 'foo', 'string': -42 }"); + v = visitor_input_test_init(data, "{ 'integer': false, 'boolean': 'foo', " + "'string': -42 }"); visit_type_TestStruct(v, &p, NULL, &err); error_free_or_abort(&err); @@ -709,6 +711,12 @@ static void test_visitor_in_errors(TestInputVisitorData *data, g_free(p->string); g_free(p); + + v = visitor_input_test_init(data, "[ '1', '2', false, '3' ]"); + visit_type_strList(v, &q, NULL, &err); + error_free_or_abort(&err); + assert(q); + qapi_free_strList(q); } int main(int argc, char **argv) |