diff options
author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2023-10-09 12:02:45 +0200 |
---|---|---|
committer | Thomas Huth <thuth@redhat.com> | 2023-10-27 09:39:08 +0200 |
commit | e33ba60bdb4729b6a2531a7d964550e27f3c100e (patch) | |
tree | f3ba775564322ab77306d89d87bec80755fecbca /tests/qtest | |
parent | 79a8d000732a967e554c0d726aaffdb08f70061b (diff) | |
download | qemu-e33ba60bdb4729b6a2531a7d964550e27f3c100e.zip qemu-e33ba60bdb4729b6a2531a7d964550e27f3c100e.tar.gz qemu-e33ba60bdb4729b6a2531a7d964550e27f3c100e.tar.bz2 |
tests/cdrom-test: Clean up global variable shadowing in prepare_image()
Rename the variable to fix:
tests/qtest/cdrom-test.c:40:50: error: declaration shadows a variable in the global scope [-Werror,-Wshadow]
static int prepare_image(const char *arch, char *isoimage)
^
tests/qtest/cdrom-test.c:18:13: note: previous declaration is here
static char isoimage[] = "cdrom-boot-iso-XXXXXX";
^
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-ID: <20231009100251.56019-5-philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/qtest')
-rw-r--r-- | tests/qtest/cdrom-test.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c index f2a8d91..0945383 100644 --- a/tests/qtest/cdrom-test.c +++ b/tests/qtest/cdrom-test.c @@ -37,17 +37,17 @@ static int exec_xorrisofs(const char **args) return exit_status; } -static int prepare_image(const char *arch, char *isoimage) +static int prepare_image(const char *arch, char *isoimagepath) { char srcdir[] = "cdrom-test-dir-XXXXXX"; char *codefile = NULL; int ifh, ret = -1; const char *args[] = { "xorrisofs", "-quiet", "-l", "-no-emul-boot", - "-b", NULL, "-o", isoimage, srcdir, NULL + "-b", NULL, "-o", isoimagepath, srcdir, NULL }; - ifh = mkstemp(isoimage); + ifh = mkstemp(isoimagepath); if (ifh < 0) { perror("Error creating temporary iso image file"); return -1; |