aboutsummaryrefslogtreecommitdiff
path: root/tests/qemu-iotests
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2019-12-16 18:02:08 +0100
committerKevin Wolf <kwolf@redhat.com>2019-12-19 14:32:43 +0100
commit7fe6bb7a34599714afa8d4e5fac612ec1fdbdb5c (patch)
tree37f5ca9885478c8365737748689db40e1624673f /tests/qemu-iotests
parent6055cdf3d9736ebb2971dc3e243fa5facdd415ee (diff)
downloadqemu-7fe6bb7a34599714afa8d4e5fac612ec1fdbdb5c.zip
qemu-7fe6bb7a34599714afa8d4e5fac612ec1fdbdb5c.tar.gz
qemu-7fe6bb7a34599714afa8d4e5fac612ec1fdbdb5c.tar.bz2
iotests: 211: Remove duplication with VM.blockdev_create()
The blockdev_create() function in this test case adds an error check that skips the test in case of failure because of memory shortage, but provides otherwise the same functionality as VM.blockdev_create() from iotests.py. Make it a thin wrapper around the iotests.py function. Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'tests/qemu-iotests')
-rwxr-xr-xtests/qemu-iotests/21112
1 files changed, 3 insertions, 9 deletions
diff --git a/tests/qemu-iotests/211 b/tests/qemu-iotests/211
index 6afc894..8834ebf 100755
--- a/tests/qemu-iotests/211
+++ b/tests/qemu-iotests/211
@@ -27,15 +27,9 @@ iotests.verify_image_format(supported_fmts=['vdi'])
iotests.verify_protocol(supported=['file'])
def blockdev_create(vm, options):
- result = vm.qmp_log('blockdev-create', job_id='job0', options=options,
- filters=[iotests.filter_qmp_testfiles])
-
- if 'return' in result:
- assert result['return'] == {}
- error = vm.run_job('job0')
- if error and 'Could not allocate bmap' in error:
- iotests.notrun('Insufficient memory')
- iotests.log("")
+ error = vm.blockdev_create(options)
+ if error and 'Could not allocate bmap' in error:
+ iotests.notrun('Insufficient memory')
with iotests.FilePath('t.vdi') as disk_path, \
iotests.VM() as vm: