diff options
| author | Max Reitz <mreitz@redhat.com> | 2017-11-14 19:01:26 +0100 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2017-11-17 18:21:30 +0100 |
| commit | 54fd1b0d260cf9615d3385c93702277e81f0b639 (patch) | |
| tree | e4d88946aee3a5b5dcda3674c980b944c9fde383 /tests/qemu-iotests | |
| parent | b38dd678a21582e03ecd2dec76ccf8290455628a (diff) | |
| download | qemu-54fd1b0d260cf9615d3385c93702277e81f0b639.zip qemu-54fd1b0d260cf9615d3385c93702277e81f0b639.tar.gz qemu-54fd1b0d260cf9615d3385c93702277e81f0b639.tar.bz2 | |
block: qobject_is_equal() in bdrv_reopen_prepare()
Currently, bdrv_reopen_prepare() assumes that all BDS options are
strings. However, this is not the case if the BDS has been created
through the json: pseudo-protocol or blockdev-add.
Note that the user-invokable reopen command is an HMP command, so you
can only specify strings there. Therefore, specifying a non-string
option with the "same" value as it was when originally created will now
return an error because the values are supposedly similar (and there is
no way for the user to circumvent this but to just not specify the
option again -- however, this is still strictly better than just
crashing).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 20171114180128.17076-5-mreitz@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'tests/qemu-iotests')
0 files changed, 0 insertions, 0 deletions