diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2021-10-18 15:47:14 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2021-11-02 13:02:46 +0100 |
| commit | bfb8aa6d583b09378dcdb85d40c7951e44acd09f (patch) | |
| tree | 9b6059ccd1c3a05b632e95590c1e39a66cb3eabc /tests/qemu-iotests/085 | |
| parent | 13a028336f2c05e7ff47dfdaf30dfac7f4883e80 (diff) | |
| download | qemu-bfb8aa6d583b09378dcdb85d40c7951e44acd09f.zip qemu-bfb8aa6d583b09378dcdb85d40c7951e44acd09f.tar.gz qemu-bfb8aa6d583b09378dcdb85d40c7951e44acd09f.tar.bz2 | |
block: Fail gracefully when blockdev-snapshot creates loops
Using blockdev-snapshot to append a node as an overlay to itself, or to
any of its parents, causes crashes. Catch the condition and return an
error for these cases instead.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1824363
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20211018134714.48438-1-kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'tests/qemu-iotests/085')
| -rwxr-xr-x | tests/qemu-iotests/085 | 31 |
1 files changed, 30 insertions, 1 deletions
diff --git a/tests/qemu-iotests/085 b/tests/qemu-iotests/085 index d557522..de74262 100755 --- a/tests/qemu-iotests/085 +++ b/tests/qemu-iotests/085 @@ -103,11 +103,18 @@ do_blockdev_add() } # ${1}: unique identifier for the snapshot filename -add_snapshot_image() +create_snapshot_image() { base_image="${TEST_DIR}/$((${1}-1))-${snapshot_virt0}" snapshot_file="${TEST_DIR}/${1}-${snapshot_virt0}" TEST_IMG=$snapshot_file _make_test_img -u -b "${base_image}" -F $IMGFMT "$size" +} + +# ${1}: unique identifier for the snapshot filename +add_snapshot_image() +{ + snapshot_file="${TEST_DIR}/${1}-${snapshot_virt0}" + create_snapshot_image "$1" do_blockdev_add "$1" "'backing': null, " "${snapshot_file}" } @@ -231,6 +238,28 @@ do_blockdev_add ${SNAPSHOTS} "" "${TEST_IMG}" blockdev_snapshot ${SNAPSHOTS} error echo +echo === Invalid command - creating loops === +echo + +SNAPSHOTS=$((${SNAPSHOTS}+1)) +add_snapshot_image ${SNAPSHOTS} + +_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot', + 'arguments': { 'node':'snap_${SNAPSHOTS}', + 'overlay':'snap_${SNAPSHOTS}' } + }" "error" + +SNAPSHOTS=$((${SNAPSHOTS}+1)) +create_snapshot_image ${SNAPSHOTS} +do_blockdev_add ${SNAPSHOTS} "'backing': 'snap_$((${SNAPSHOTS}-1))', " \ + "${TEST_DIR}/${SNAPSHOTS}-${snapshot_virt0}" + +_send_qemu_cmd $h "{ 'execute': 'blockdev-snapshot', + 'arguments': { 'node':'snap_${SNAPSHOTS}', + 'overlay':'snap_$((${SNAPSHOTS}-1))' } + }" "error" + +echo echo === Invalid command - The node does not exist === echo |