aboutsummaryrefslogtreecommitdiff
path: root/tests/fdc-test.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2018-08-06 08:53:25 +0200
committerMarkus Armbruster <armbru@redhat.com>2018-08-16 08:42:06 +0200
commit055a1efc7c5a30ca0993720da57ba70179d28c7b (patch)
treea64a16a0cf3cc6e3f1f8dff8289b20d6b10549d6 /tests/fdc-test.c
parentbe62e1724f383c9e5012732af6c4dce587a917ee (diff)
downloadqemu-055a1efc7c5a30ca0993720da57ba70179d28c7b.zip
qemu-055a1efc7c5a30ca0993720da57ba70179d28c7b.tar.gz
qemu-055a1efc7c5a30ca0993720da57ba70179d28c7b.tar.bz2
libqtest: Remove qtest_qmp_discard_response() & friends
qtest_qmp_discard_response(...) is shorthand for qobject_unref(qtest_qmp(...), except it's not actually shorter. Moreover, the presence of these functions encourage sloppy testing. Remove them from libqtest. Add them as macros to the tests that use them, with a TODO comment asking for cleanup. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20180806065344.7103-5-armbru@redhat.com> Reviewed-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/fdc-test.c')
-rw-r--r--tests/fdc-test.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/tests/fdc-test.c b/tests/fdc-test.c
index 325712e..88f1abf 100644
--- a/tests/fdc-test.c
+++ b/tests/fdc-test.c
@@ -26,8 +26,12 @@
#include "libqtest.h"
+#include "qapi/qmp/qdict.h"
#include "qemu-common.h"
+/* TODO actually test the results and get rid of this */
+#define qmp_discard_response(...) qobject_unref(qmp(__VA_ARGS__))
+
#define TEST_IMAGE_SIZE 1440 * 1024
#define FLOPPY_BASE 0x3f0