aboutsummaryrefslogtreecommitdiff
path: root/tests/avocado/avocado_qemu
diff options
context:
space:
mode:
authorThomas Huth <thuth@redhat.com>2022-02-28 12:43:25 +0100
committerThomas Huth <thuth@redhat.com>2022-03-07 18:59:44 +0100
commit8c88e1782ffd0504c7fce1f5d2f687aa329fd593 (patch)
treef49500aef7a0179a37c9f397111af44fb01c7dfe /tests/avocado/avocado_qemu
parent5be6fd0cb95e9c684c0b8685b979c9b5f63f6057 (diff)
downloadqemu-8c88e1782ffd0504c7fce1f5d2f687aa329fd593.zip
qemu-8c88e1782ffd0504c7fce1f5d2f687aa329fd593.tar.gz
qemu-8c88e1782ffd0504c7fce1f5d2f687aa329fd593.tar.bz2
tests/avocado: Cancel BootLinux tests in case there is no free port
The BootLinux tests are currently failing with an ugly python stack trace on my RHEL8 system since they cannot get a free port (likely due to the firewall settings on my system). Let's properly check the return value of find_free_port() instead and cancel the test gracefully if it cannot get a free port. Message-Id: <20220228114325.818294-1-thuth@redhat.com> Reviewed-by: Beraldo Leal <bleal@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'tests/avocado/avocado_qemu')
-rw-r--r--tests/avocado/avocado_qemu/__init__.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado_qemu/__init__.py
index 75063c0..9b056b5 100644
--- a/tests/avocado/avocado_qemu/__init__.py
+++ b/tests/avocado/avocado_qemu/__init__.py
@@ -603,6 +603,8 @@ class LinuxTest(LinuxSSHMixIn, QemuSystemTest):
try:
cloudinit_iso = os.path.join(self.workdir, 'cloudinit.iso')
self.phone_home_port = network.find_free_port()
+ if not self.phone_home_port:
+ self.cancel('Failed to get a free port')
pubkey_content = None
if ssh_pubkey:
with open(ssh_pubkey) as pubkey: