aboutsummaryrefslogtreecommitdiff
path: root/target
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2019-02-01 14:55:44 +0000
committerPeter Maydell <peter.maydell@linaro.org>2019-02-01 14:55:44 +0000
commita80c4256543987ca88407349ee012a673a10a2ae (patch)
tree3e8a12c295cf309cde64a33fa8ea65c341531ecb /target
parent08d5e3bde6b4ad32996bf69d93aa66ae43d3f3ff (diff)
downloadqemu-a80c4256543987ca88407349ee012a673a10a2ae.zip
qemu-a80c4256543987ca88407349ee012a673a10a2ae.tar.gz
qemu-a80c4256543987ca88407349ee012a673a10a2ae.tar.bz2
target/arm/translate-a64: Don't underdecode PRFM
The PRFM prefetch insn in the load/store with imm9 encodings requires idx field 0b00; we were underdecoding this by only checking !is_unpriv (which is equivalent to idx != 2). Correctly UNDEF the unallocated encodings where idx == 0b01 and 0b11 as well as 0b10. Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com> Message-id: 20190125182626.9221-3-peter.maydell@linaro.org
Diffstat (limited to 'target')
-rw-r--r--target/arm/translate-a64.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index e6df303..8e08175 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -2803,7 +2803,7 @@ static void disas_ldst_reg_imm9(DisasContext *s, uint32_t insn,
} else {
if (size == 3 && opc == 2) {
/* PRFM - prefetch */
- if (is_unpriv) {
+ if (idx != 0) {
unallocated_encoding(s);
return;
}