diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2022-07-19 20:17:37 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2022-08-08 23:22:36 +0200 |
| commit | 8809baf4e40633ba01b47cd2257bbbbba14fc861 (patch) | |
| tree | fe49f92342096b585ce9e64e0eafda5546aa1b54 /target | |
| parent | 8a1337e60400ef54432e063164faf5043a55555d (diff) | |
| download | qemu-8809baf4e40633ba01b47cd2257bbbbba14fc861.zip qemu-8809baf4e40633ba01b47cd2257bbbbba14fc861.tar.gz qemu-8809baf4e40633ba01b47cd2257bbbbba14fc861.tar.bz2 | |
target/mips: Handle lock_user() failure in UHI_plog semihosting call
Coverity notes that we forgot to check the error return from
lock_user() in one place in the handling of the UHI_plog semihosting
call. Add the missing error handling.
report_fault() is rather brutal in that it will call abort(), but
this is the same error-handling used in the rest of this file.
Resolves: Coverity CID 1490684
Fixes: ea4210600db3c5 ("target/mips: Avoid qemu_semihosting_log_out for UHI_plog")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220719191737.384744-1-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Diffstat (limited to 'target')
| -rw-r--r-- | target/mips/tcg/sysemu/mips-semi.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/target/mips/tcg/sysemu/mips-semi.c b/target/mips/tcg/sysemu/mips-semi.c index 5fb1ad9..85f0567 100644 --- a/target/mips/tcg/sysemu/mips-semi.c +++ b/target/mips/tcg/sysemu/mips-semi.c @@ -321,6 +321,9 @@ void mips_semihosting(CPUMIPSState *env) if (use_gdb_syscalls()) { addr = gpr[29] - str->len; p = lock_user(VERIFY_WRITE, addr, str->len, 0); + if (!p) { + report_fault(env); + } memcpy(p, str->str, str->len); unlock_user(p, addr, str->len); semihost_sys_write(cs, uhi_cb, 2, addr, str->len); |