aboutsummaryrefslogtreecommitdiff
path: root/target
diff options
context:
space:
mode:
authorRichard Henderson <richard.henderson@linaro.org>2022-06-01 18:33:47 -0700
committerLaurent Vivier <laurent@vivier.eu>2022-06-02 09:35:02 +0200
commiteeb8f7b0f84f86b5fa1e17aed851d758e1c7ee0f (patch)
tree9f65ef07d4e9b998b1797d4fa908076603f6fb2e /target
parent02ea42b36ddcd34739c9320ae2262b1d1e814a6d (diff)
downloadqemu-eeb8f7b0f84f86b5fa1e17aed851d758e1c7ee0f.zip
qemu-eeb8f7b0f84f86b5fa1e17aed851d758e1c7ee0f.tar.gz
qemu-eeb8f7b0f84f86b5fa1e17aed851d758e1c7ee0f.tar.bz2
target/m68k: Fix coding style in m68k_interrupt_all
Add parenthesis around & vs &&. Remove assignment to sr in function call argument -- note that sr is unused after the call, so the assignment was never needed, only the result of the & expression. Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Laurent Vivier <laurent@vivier.eu> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20220602013401.303699-4-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'target')
-rw-r--r--target/m68k/op_helper.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c
index 2b94a6e..0f41c2d 100644
--- a/target/m68k/op_helper.c
+++ b/target/m68k/op_helper.c
@@ -408,11 +408,11 @@ static void m68k_interrupt_all(CPUM68KState *env, int is_hw)
break;
case EXCP_SPURIOUS ... EXCP_INT_LEVEL_7:
- if (is_hw && oldsr & SR_M) {
+ if (is_hw && (oldsr & SR_M)) {
do_stack_frame(env, &sp, 0, oldsr, 0, retaddr);
oldsr = sr;
env->aregs[7] = sp;
- cpu_m68k_set_sr(env, sr &= ~SR_M);
+ cpu_m68k_set_sr(env, sr & ~SR_M);
sp = env->aregs[7];
if (!m68k_feature(env, M68K_FEATURE_UNALIGNED_DATA)) {
sp &= ~1;