aboutsummaryrefslogtreecommitdiff
path: root/target
diff options
context:
space:
mode:
authorRichard Henderson <richard.henderson@linaro.org>2023-04-08 00:05:47 -0700
committerCédric Le Goater <clg@kaod.org>2023-04-09 19:21:27 +0200
commita253231fbede6e69bf287afd90f67347a7383aab (patch)
treeb7e4a13a6e883265b7945cb993085ce01866fc35 /target
parentc6f3cbca32bde9ee94d9949aa63e8a7ef2d7bc5b (diff)
downloadqemu-a253231fbede6e69bf287afd90f67347a7383aab.zip
qemu-a253231fbede6e69bf287afd90f67347a7383aab.tar.gz
qemu-a253231fbede6e69bf287afd90f67347a7383aab.tar.bz2
target/ppc: Fix temp usage in gen_op_arith_modw
Fix a crash writing to 't3', which is now a constant. Instead, write the result of the remu to 't0'. Fixes: 7058ff5231a ("target/ppc: Avoid tcg_const_* in translate.c") Reported-by: Nicholas Piggin <npiggin@gmail.com> Reviewed-by: Anton Johansson <anjo@rev.ng> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> [ clg: amend commit log s/t1/t0/ ] Signed-off-by: Cédric Le Goater <clg@kaod.org>
Diffstat (limited to 'target')
-rw-r--r--target/ppc/translate.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 9d05357..f603f1a 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -1807,8 +1807,8 @@ static inline void gen_op_arith_modw(DisasContext *ctx, TCGv ret, TCGv arg1,
TCGv_i32 t2 = tcg_constant_i32(1);
TCGv_i32 t3 = tcg_constant_i32(0);
tcg_gen_movcond_i32(TCG_COND_EQ, t1, t1, t3, t2, t1);
- tcg_gen_remu_i32(t3, t0, t1);
- tcg_gen_extu_i32_tl(ret, t3);
+ tcg_gen_remu_i32(t0, t0, t1);
+ tcg_gen_extu_i32_tl(ret, t0);
}
}