diff options
| author | Michael Lambert <mlambert@quicinc.com> | 2022-02-09 18:15:45 -0800 |
|---|---|---|
| committer | Taylor Simpson <tsimpson@quicinc.com> | 2022-03-12 09:14:22 -0800 |
| commit | 58ff2981667262f77d57219fc9cef2a43a740159 (patch) | |
| tree | fbe8008234bcedcfe8405d9b57137a12d8ae9e7a /target | |
| parent | 1416688c53be6535be755b44c15fb2eb9defd20f (diff) | |
| download | qemu-58ff2981667262f77d57219fc9cef2a43a740159.zip qemu-58ff2981667262f77d57219fc9cef2a43a740159.tar.gz qemu-58ff2981667262f77d57219fc9cef2a43a740159.tar.bz2 | |
Hexagon (target/hexagon) fix bug in circular addressing
Versions V3 and earlier should treat the "K_const" and "length" values
as unsigned.
Modified circ_test_v3() in tests/tcg/hexagon/circ.c to reproduce the bug
Signed-off-by: Michael Lambert <mlambert@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <20220210021556.9217-2-tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'target')
| -rw-r--r-- | target/hexagon/op_helper.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 057baf9..47bd51e 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -1,5 +1,5 @@ /* - * Copyright(c) 2019-2021 Qualcomm Innovation Center, Inc. All Rights Reserved. + * Copyright(c) 2019-2022 Qualcomm Innovation Center, Inc. All Rights Reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -304,8 +304,8 @@ void HELPER(debug_commit_end)(CPUHexagonState *env, int has_st0, int has_st1) int32_t HELPER(fcircadd)(int32_t RxV, int32_t offset, int32_t M, int32_t CS) { - int32_t K_const = sextract32(M, 24, 4); - int32_t length = sextract32(M, 0, 17); + uint32_t K_const = extract32(M, 24, 4); + uint32_t length = extract32(M, 0, 17); uint32_t new_ptr = RxV + offset; uint32_t start_addr; uint32_t end_addr; |