diff options
| author | Chen Qun <kuhn.chenqun@huawei.com> | 2020-11-16 10:48:10 +0800 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2020-12-14 15:50:55 +1100 |
| commit | cf77e27f1e16d8eca761e5c966ea80291254a32c (patch) | |
| tree | ce1f17bf51697579d52acb5f76f1dfd39d7dbc58 /target | |
| parent | ac96807b0245f08d969a8faf0c8c754514bb6c10 (diff) | |
| download | qemu-cf77e27f1e16d8eca761e5c966ea80291254a32c.zip qemu-cf77e27f1e16d8eca761e5c966ea80291254a32c.tar.gz qemu-cf77e27f1e16d8eca761e5c966ea80291254a32c.tar.bz2 | |
target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
target/ppc/mmu_helper.c: In function ‘dump_mmu’:
target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through [-Wimplicit-fallthrough=]
1351 | if (ppc64_v3_radix(env_archcpu(env))) {
| ^
target/ppc/mmu_helper.c:1358:5: note: here
1358 | default:
| ^~~~~~~
Use "qemu_log_mask(LOG_UNIMP**)" instead of the TODO comment.
And add the break statement to fix it.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20201116024810.2415819-8-kuhn.chenqun@huawei.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'target')
| -rw-r--r-- | target/ppc/mmu_helper.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index 064d2e8..9f22b66 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -1349,11 +1349,12 @@ void dump_mmu(CPUPPCState *env) break; case POWERPC_MMU_3_00: if (ppc64_v3_radix(env_archcpu(env))) { - /* TODO - Unsupported */ + qemu_log_mask(LOG_UNIMP, "%s: the PPC64 MMU is unsupported\n", + __func__); } else { dump_slb(env_archcpu(env)); - break; } + break; #endif default: qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__); |