diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2018-03-22 16:49:28 +1100 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2018-04-27 18:05:22 +1000 |
| commit | 8fe08fac1939815950b74fb7eb17101320450ca7 (patch) | |
| tree | 92d7f05e789ef88548a0ff0b813791d9ac7d8a5f /target/ppc/mmu-hash64.h | |
| parent | 644a2c99a90b95957fd56fc3b9f8908ac9e90702 (diff) | |
| download | qemu-8fe08fac1939815950b74fb7eb17101320450ca7.zip qemu-8fe08fac1939815950b74fb7eb17101320450ca7.tar.gz qemu-8fe08fac1939815950b74fb7eb17101320450ca7.tar.bz2 | |
target/ppc: Avoid taking "env" parameter to mmu-hash64 functions
In most cases we prefer to pass a PowerPCCPU rather than the (embedded)
CPUPPCState.
For ppc_hash64_update_{rmls,vrma}() change to take "cpu" instead of "env".
For ppc_hash64_set_{dsi,isi}() remove the redundant "env" parameter.
In theory this makes more work for the functions, but since "cs", "cpu"
and "env" are related by at most constant offsets, the compiler should be
able to optimize out the difference at effectively zero cost.
helper_*() functions are left alone - since they're more closely tied to
the TCG generated code, passing "env" is still the standard there.
While we're there, fix an incorrect indentation.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Diffstat (limited to 'target/ppc/mmu-hash64.h')
| -rw-r--r-- | target/ppc/mmu-hash64.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/target/ppc/mmu-hash64.h b/target/ppc/mmu-hash64.h index d297b97..95a8c33 100644 --- a/target/ppc/mmu-hash64.h +++ b/target/ppc/mmu-hash64.h @@ -17,8 +17,8 @@ void ppc_hash64_tlb_flush_hpte(PowerPCCPU *cpu, target_ulong pte0, target_ulong pte1); unsigned ppc_hash64_hpte_page_shift_noslb(PowerPCCPU *cpu, uint64_t pte0, uint64_t pte1); -void ppc_hash64_update_vrma(CPUPPCState *env); -void ppc_hash64_update_rmls(CPUPPCState *env); +void ppc_hash64_update_vrma(PowerPCCPU *cpu); +void ppc_hash64_update_rmls(PowerPCCPU *cpu); #endif /* |