diff options
| author | Markus Armbruster <armbru@redhat.com> | 2018-02-01 12:18:28 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2018-02-09 05:05:11 +0100 |
| commit | d8e39b70625d4ba1e998439d1a077b4b978930e7 (patch) | |
| tree | e12c529c79aaf80d2ef02efa1e677ef1d4ca4a51 /target/i386/hvf | |
| parent | 637b047717fdeb6ffcd2fe7dff691a53f3804f42 (diff) | |
| download | qemu-d8e39b70625d4ba1e998439d1a077b4b978930e7.zip qemu-d8e39b70625d4ba1e998439d1a077b4b978930e7.tar.gz qemu-d8e39b70625d4ba1e998439d1a077b4b978930e7.tar.bz2 | |
Use #include "..." for our own headers, <...> for others
System headers should be included with <...>, our own headers with
"...". Offenders tracked down with an ugly, brittle and probably
buggy Perl script. Previous iteration was commit a9c94277f0.
Delete inclusions of "string.h" and "strings.h" instead of fixing them
to <string.h> and <strings.h>, because we always include these via
osdep.h.
Put the cleaned up system header includes first.
While there, separate #include from file comment with exactly one
blank line.
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20180201111846.21846-2-armbru@redhat.com>
Diffstat (limited to 'target/i386/hvf')
| -rw-r--r-- | target/i386/hvf/hvf.c | 1 | ||||
| -rw-r--r-- | target/i386/hvf/x86_decode.c | 1 | ||||
| -rw-r--r-- | target/i386/hvf/x86_mmu.c | 6 | ||||
| -rw-r--r-- | target/i386/hvf/x86_task.c | 1 |
4 files changed, 2 insertions, 7 deletions
diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 85e5964..15870a4 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -70,7 +70,6 @@ #include "hw/i386/apic_internal.h" #include "hw/boards.h" #include "qemu/main-loop.h" -#include "strings.h" #include "sysemu/accel.h" #include "sysemu/sysemu.h" #include "target/i386/cpu.h" diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c index bf93e82..2d7540f 100644 --- a/target/i386/hvf/x86_decode.c +++ b/target/i386/hvf/x86_decode.c @@ -21,7 +21,6 @@ #include "qemu-common.h" #include "panic.h" #include "x86_decode.h" -#include "string.h" #include "vmx.h" #include "x86_mmu.h" #include "x86_descr.h" diff --git a/target/i386/hvf/x86_mmu.c b/target/i386/hvf/x86_mmu.c index 5c1f35a..c6be2cc 100644 --- a/target/i386/hvf/x86_mmu.c +++ b/target/i386/hvf/x86_mmu.c @@ -15,18 +15,16 @@ * You should have received a copy of the GNU Lesser General Public * License along with this program; if not, see <http://www.gnu.org/licenses/>. */ + #include "qemu/osdep.h" +#include <memory.h> #include "panic.h" - #include "qemu-common.h" #include "cpu.h" #include "x86.h" #include "x86_mmu.h" -#include "string.h" #include "vmcs.h" #include "vmx.h" - -#include "memory.h" #include "exec/address-spaces.h" #define pte_present(pte) (pte & PT_PRESENT) diff --git a/target/i386/hvf/x86_task.c b/target/i386/hvf/x86_task.c index d7f665f..4abf3db 100644 --- a/target/i386/hvf/x86_task.c +++ b/target/i386/hvf/x86_task.c @@ -32,7 +32,6 @@ #include "hw/i386/apic_internal.h" #include "hw/boards.h" #include "qemu/main-loop.h" -#include "strings.h" #include "sysemu/accel.h" #include "sysemu/sysemu.h" #include "target/i386/cpu.h" |