aboutsummaryrefslogtreecommitdiff
path: root/target/hppa/gdbstub.c
diff options
context:
space:
mode:
authorSven Schnelle <svens@stackframe.org>2019-01-28 17:53:33 +0100
committerRichard Henderson <richard.henderson@linaro.org>2019-02-06 10:49:21 +0000
commit5c41496dd780fed67eadd64c59fc2cf21717ecf0 (patch)
treeeea97104e928aec3bbc10f61dc4d27dbb435f1ed /target/hppa/gdbstub.c
parent84b41e658b02a6738b47cc4e03176f1b81d9e1d1 (diff)
downloadqemu-5c41496dd780fed67eadd64c59fc2cf21717ecf0.zip
qemu-5c41496dd780fed67eadd64c59fc2cf21717ecf0.tar.gz
qemu-5c41496dd780fed67eadd64c59fc2cf21717ecf0.tar.bz2
target/hppa: fix setting registers via gdb
While doing 'set $pcoqh=0xf0000000' i triggered the assertion below. The argument order for deposit64() is wrong, and val needs to be moved to the end. Signed-off-by: Sven Schnelle <svens@stackframe.org> Message-Id: <20190128165333.3814-1-svens@stackframe.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Diffstat (limited to 'target/hppa/gdbstub.c')
-rw-r--r--target/hppa/gdbstub.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/target/hppa/gdbstub.c b/target/hppa/gdbstub.c
index e2e9c4d..3157a69 100644
--- a/target/hppa/gdbstub.c
+++ b/target/hppa/gdbstub.c
@@ -266,7 +266,7 @@ int hppa_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
case 65 ... 127:
{
uint64_t *fr = &env->fr[(n - 64) / 2];
- *fr = deposit64(*fr, val, (n & 1 ? 0 : 32), 32);
+ *fr = deposit64(*fr, (n & 1 ? 0 : 32), 32, val);
}
break;
default: