diff options
author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /target/arm | |
parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
download | qemu-db725815985654007ade0fd53590d613fd657208.zip qemu-db725815985654007ade0fd53590d613fd657208.tar.gz qemu-db725815985654007ade0fd53590d613fd657208.tar.bz2 |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'target/arm')
-rw-r--r-- | target/arm/helper-a64.c | 1 | ||||
-rw-r--r-- | target/arm/helper.c | 2 | ||||
-rw-r--r-- | target/arm/kvm.c | 1 | ||||
-rw-r--r-- | target/arm/kvm64.c | 1 | ||||
-rw-r--r-- | target/arm/m_helper.c | 2 | ||||
-rw-r--r-- | target/arm/psci.c | 2 |
6 files changed, 9 insertions, 0 deletions
diff --git a/target/arm/helper-a64.c b/target/arm/helper-a64.c index 060699b..616d62c 100644 --- a/target/arm/helper-a64.c +++ b/target/arm/helper-a64.c @@ -23,6 +23,7 @@ #include "exec/helper-proto.h" #include "qemu/host-utils.h" #include "qemu/log.h" +#include "qemu/main-loop.h" #include "sysemu/sysemu.h" #include "qemu/bitops.h" #include "internals.h" diff --git a/target/arm/helper.c b/target/arm/helper.c index 75b66bf..210f583 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -5,6 +5,7 @@ * * SPDX-License-Identifier: GPL-2.0-or-later */ + #include "qemu/osdep.h" #include "qemu/units.h" #include "target/arm/idau.h" @@ -14,6 +15,7 @@ #include "exec/gdbstub.h" #include "exec/helper-proto.h" #include "qemu/host-utils.h" +#include "qemu/main-loop.h" #include "sysemu/sysemu.h" #include "qemu/bitops.h" #include "qemu/crc32c.h" diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 36a1e60..b5713e3 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -16,6 +16,7 @@ #include "qemu-common.h" #include "qemu/timer.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "sysemu/sysemu.h" #include "sysemu/kvm.h" #include "sysemu/kvm_int.h" diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 22d19c9..c76d3d7 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -21,6 +21,7 @@ #include "qemu/timer.h" #include "qemu/error-report.h" #include "qemu/host-utils.h" +#include "qemu/main-loop.h" #include "exec/gdbstub.h" #include "sysemu/sysemu.h" #include "sysemu/kvm.h" diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c index 84609f4..cde5195 100644 --- a/target/arm/m_helper.c +++ b/target/arm/m_helper.c @@ -5,6 +5,7 @@ * * SPDX-License-Identifier: GPL-2.0-or-later */ + #include "qemu/osdep.h" #include "qemu/units.h" #include "target/arm/idau.h" @@ -14,6 +15,7 @@ #include "exec/gdbstub.h" #include "exec/helper-proto.h" #include "qemu/host-utils.h" +#include "qemu/main-loop.h" #include "sysemu/sysemu.h" #include "qemu/bitops.h" #include "qemu/crc32c.h" diff --git a/target/arm/psci.c b/target/arm/psci.c index a74d788..af1d5a5 100644 --- a/target/arm/psci.c +++ b/target/arm/psci.c @@ -15,10 +15,12 @@ * You should have received a copy of the GNU General Public License * along with this program; if not, see <http://www.gnu.org/licenses/>. */ + #include "qemu/osdep.h" #include "cpu.h" #include "exec/helper-proto.h" #include "kvm-consts.h" +#include "qemu/main-loop.h" #include "sysemu/sysemu.h" #include "internals.h" #include "arm-powerctl.h" |