aboutsummaryrefslogtreecommitdiff
path: root/target-tricore
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2015-06-24 14:01:10 +0200
committerBastian Koppelmann <kbastian@mail.uni-paderborn.de>2015-06-29 14:02:58 +0200
commit5f37fd8e2980818ab71bc4b4e21129e29acd73f7 (patch)
tree06ae381ccdd91de0c76e762011d7ee9f09e2bc63 /target-tricore
parentdc1e1350f8061021df765b396295329797d66933 (diff)
downloadqemu-5f37fd8e2980818ab71bc4b4e21129e29acd73f7.zip
qemu-5f37fd8e2980818ab71bc4b4e21129e29acd73f7.tar.gz
qemu-5f37fd8e2980818ab71bc4b4e21129e29acd73f7.tar.bz2
target-tricore: fix depositing bits from PCXI into ICR
Spotted by Coverity, because (env->PCXI & MASK_PCXI_PCPN) >> 24 is always zero. The immediately preceding assignment is also wrong though. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Message-Id: <1435147270-1040-1-git-send-email-pbonzini@redhat.com>
Diffstat (limited to 'target-tricore')
-rw-r--r--target-tricore/op_helper.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c
index 10ed541..53edbda 100644
--- a/target-tricore/op_helper.c
+++ b/target-tricore/op_helper.c
@@ -2545,10 +2545,10 @@ void helper_rfm(CPUTriCoreState *env)
env->PC = (env->gpr_a[11] & ~0x1);
/* ICR.IE = PCXI.PIE; */
env->ICR = (env->ICR & ~MASK_ICR_IE) |
- ((env->PCXI & ~MASK_PCXI_PIE) >> 15);
+ ((env->PCXI & MASK_PCXI_PIE) >> 15);
/* ICR.CCPN = PCXI.PCPN; */
env->ICR = (env->ICR & ~MASK_ICR_CCPN) |
- ((env->PCXI & ~MASK_PCXI_PCPN) >> 24);
+ ((env->PCXI & MASK_PCXI_PCPN) >> 24);
/* {PCXI, PSW, A[10], A[11]} = M(DCX, 4 * word); */
env->PCXI = cpu_ldl_data(env, env->DCX);
psw_write(env, cpu_ldl_data(env, env->DCX+4));