diff options
| author | Richard Henderson <rth@twiddle.net> | 2016-09-22 15:17:10 -0700 |
|---|---|---|
| committer | Richard Henderson <rth@twiddle.net> | 2016-11-01 10:29:03 -0600 |
| commit | 1ee73216f4ccd2f3b6eb818feb165b3cf5a1944c (patch) | |
| tree | c4bf6e9433b8c0104e384233fa09a78346673709 /target-i386/translate.c | |
| parent | 9acbf7d8cad3d3af498e4e907fb1f5ab27a302e9 (diff) | |
| download | qemu-1ee73216f4ccd2f3b6eb818feb165b3cf5a1944c.zip qemu-1ee73216f4ccd2f3b6eb818feb165b3cf5a1944c.tar.gz qemu-1ee73216f4ccd2f3b6eb818feb165b3cf5a1944c.tar.bz2 | |
log: Add locking to large logging blocks
Reuse the existing locking provided by stdio to keep in_asm, cpu,
op, op_opt, op_ind, and out_asm as contiguous blocks.
While it isn't possible to interleave e.g. in_asm or op_opt logs
because of the TB lock protecting all code generation, it is
possible to interleave cpu logs, or to interleave a cpu dump with
an out_asm dump.
For mingw32, we appear to have no viable solution for this. The locking
functions are not properly exported from the system runtime library.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Diffstat (limited to 'target-i386/translate.c')
| -rw-r--r-- | target-i386/translate.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/target-i386/translate.c b/target-i386/translate.c index 927b366..324103c 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -2432,11 +2432,13 @@ static void gen_unknown_opcode(CPUX86State *env, DisasContext *s) if (qemu_loglevel_mask(LOG_UNIMP)) { target_ulong pc = s->pc_start, end = s->pc; + qemu_log_lock(); qemu_log("ILLOPC: " TARGET_FMT_lx ":", pc); for (; pc < end; ++pc) { qemu_log(" %02x", cpu_ldub_code(env, pc)); } qemu_log("\n"); + qemu_log_unlock(); } } @@ -8470,6 +8472,7 @@ done_generating: if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) && qemu_log_in_addr_range(pc_start)) { int disas_flags; + qemu_log_lock(); qemu_log("----------------\n"); qemu_log("IN: %s\n", lookup_symbol(pc_start)); #ifdef TARGET_X86_64 @@ -8480,6 +8483,7 @@ done_generating: disas_flags = !dc->code32; log_target_disas(cs, pc_start, pc_ptr - pc_start, disas_flags); qemu_log("\n"); + qemu_log_unlock(); } #endif |