diff options
| author | Edgar E. Iglesias <edgar.iglesias@xilinx.com> | 2016-05-12 13:22:27 +0100 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2016-05-12 13:22:27 +0100 |
| commit | 026a19c3128678d4fe301fc36e8ffacdc9ecccb8 (patch) | |
| tree | 42e4ca86c2f21140d54cb5302aeee0075d248195 /target-arm | |
| parent | 094d028a7968236cd2b7f7b96394f7a3b8ad97c8 (diff) | |
| download | qemu-026a19c3128678d4fe301fc36e8ffacdc9ecccb8.zip qemu-026a19c3128678d4fe301fc36e8ffacdc9ecccb8.tar.gz qemu-026a19c3128678d4fe301fc36e8ffacdc9ecccb8.tar.bz2 | |
target-arm/translate-a64.c: Use extract32 in disas_ldst_reg_imm9
Use extract32 instead of open coding the bit masking when decoding
is_signed and is_extended. This streamlines the decoding with some
of the other ldst variants.
No functional change.
Reviewed-by: Sergey Fedorov <serge.fdrv@gmail.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Message-id: 1461931684-1867-6-git-send-email-edgar.iglesias@gmail.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Diffstat (limited to 'target-arm')
| -rw-r--r-- | target-arm/translate-a64.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index b13cff7..5c8dddb 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -2128,8 +2128,8 @@ static void disas_ldst_reg_imm9(DisasContext *s, uint32_t insn) return; } is_store = (opc == 0); - is_signed = opc & (1<<1); - is_extended = (size < 3) && (opc & 1); + is_signed = extract32(opc, 1, 1); + is_extended = (size < 3) && extract32(opc, 0, 1); } switch (idx) { |