diff options
author | Paolo Bonzini <pbonzini@redhat.com> | 2012-08-19 00:12:39 +0200 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2012-08-20 15:50:45 +0200 |
commit | b20909195745c34a819aed14ae996b60ab0f591f (patch) | |
tree | 830f04a59eae29078009cfb513b52caa1f03f23b /softmmu_defs.h | |
parent | e89001f72edde37fb36fa7c964daa1bbeb2eca26 (diff) | |
download | qemu-b20909195745c34a819aed14ae996b60ab0f591f.zip qemu-b20909195745c34a819aed14ae996b60ab0f591f.tar.gz qemu-b20909195745c34a819aed14ae996b60ab0f591f.tar.bz2 |
Revert "iscsi: Fix NULL dereferences / races between task completion and abort"
This reverts commit 64e69e80920d82df3fa679bc41b13770d2f99360. The commit
returned immediately from iscsi_aio_cancel, risking corruption in case the
following happens:
guest qemu target
=========================================================================
send write 1 -------->
send write 1 -------->
cancel write 1 ------>
cancel write 1 ------>
<------------------ cancellation processed
send write 2 -------->
send write 2 -------->
<---------------- completed write 2
<------------------ completed write 2
<---------------- completed write 1
<---------------- cancellation not done
Here, the guest would see write 2 superseding write 1, when in fact the
outcome could have been the opposite. The right behavior is to return
only after the target says whether the cancellation was done or not, and
it will be implemented by the next three patches.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'softmmu_defs.h')
0 files changed, 0 insertions, 0 deletions