aboutsummaryrefslogtreecommitdiff
path: root/softmmu
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2020-10-20 17:01:19 +1100
committerDavid Gibson <david@gibson.dropbear.id.au>2021-02-08 16:57:38 +1100
commitabc27d4241f99bfaebb0b843b9a967d557ac10e8 (patch)
treeda384090a8bcbcd5476b1f2bc58f11dc0033f0f9 /softmmu
parentc9f5aaa6bce819c1863c2a56b187cb9eb521fc92 (diff)
downloadqemu-abc27d4241f99bfaebb0b843b9a967d557ac10e8.zip
qemu-abc27d4241f99bfaebb0b843b9a967d557ac10e8.tar.gz
qemu-abc27d4241f99bfaebb0b843b9a967d557ac10e8.tar.bz2
confidential guest support: Introduce cgs "ready" flag
The platform specific details of mechanisms for implementing confidential guest support may require setup at various points during initialization. Thus, it's not really feasible to have a single cgs initialization hook, but instead each mechanism needs its own initialization calls in arch or machine specific code. However, to make it harder to have a bug where a mechanism isn't properly initialized under some circumstances, we want to have a common place, late in boot, where we verify that cgs has been initialized if it was requested. This patch introduces a ready flag to the ConfidentialGuestSupport base type to accomplish this, which we verify in qemu_machine_creation_done(). Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Greg Kurz <groug@kaod.org>
Diffstat (limited to 'softmmu')
-rw-r--r--softmmu/vl.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 0d93484..9eb9dab 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -101,6 +101,7 @@
#include "qemu/plugin.h"
#include "qemu/queue.h"
#include "sysemu/arch_init.h"
+#include "exec/confidential-guest-support.h"
#include "ui/qemu-spice.h"
#include "qapi/string-input-visitor.h"
@@ -2498,6 +2499,8 @@ static void qemu_create_cli_devices(void)
static void qemu_machine_creation_done(void)
{
+ MachineState *machine = MACHINE(qdev_get_machine());
+
/* Did we create any drives that we failed to create a device for? */
drive_check_orphaned();
@@ -2517,6 +2520,13 @@ static void qemu_machine_creation_done(void)
qdev_machine_creation_done();
+ if (machine->cgs) {
+ /*
+ * Verify that Confidential Guest Support has actually been initialized
+ */
+ assert(machine->cgs->ready);
+ }
+
if (foreach_device_config(DEV_GDB, gdbserver_start) < 0) {
exit(1);
}