diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2017-05-04 02:38:45 +0400 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2017-05-27 23:34:47 +0200 |
| commit | 7d8246960e03dabf37726c01d231e89dfde9b229 (patch) | |
| tree | 557b855d3213469ba9319339b2c48a9d205e0b0b /slirp/socket.c | |
| parent | c7990a26480032ad129f8c4ddad7d9a132c934ca (diff) | |
| download | qemu-7d8246960e03dabf37726c01d231e89dfde9b229.zip qemu-7d8246960e03dabf37726c01d231e89dfde9b229.tar.gz qemu-7d8246960e03dabf37726c01d231e89dfde9b229.tar.bz2 | |
slirp: fix leak
Spotted by ASAN:
/x86_64/hmp/pc-0.12:
=================================================================
==22538==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 224 byte(s) in 1 object(s) allocated from:
#0 0x7f0f63cdee60 in malloc (/lib64/libasan.so.3+0xc6e60)
#1 0x556f11ff32d7 in tcp_newtcpcb /home/elmarco/src/qemu/slirp/tcp_subr.c:250
#2 0x556f11fdb1d1 in tcp_listen /home/elmarco/src/qemu/slirp/socket.c:688
#3 0x556f11fca9d5 in slirp_add_hostfwd /home/elmarco/src/qemu/slirp/slirp.c:1052
#4 0x556f11f8db41 in slirp_hostfwd /home/elmarco/src/qemu/net/slirp.c:506
#5 0x556f11f8dd83 in hmp_hostfwd_add /home/elmarco/src/qemu/net/slirp.c:535
There might be a better way to fix this, but calling slirp tcp_close()
doesn't work.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Diffstat (limited to 'slirp/socket.c')
| -rw-r--r-- | slirp/socket.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/slirp/socket.c b/slirp/socket.c index 8692772..3b49a69 100644 --- a/slirp/socket.c +++ b/slirp/socket.c @@ -100,6 +100,9 @@ sofree(struct socket *so) if(so->so_next && so->so_prev) remque(so); /* crashes if so is not in a queue */ + if (so->so_tcpcb) { + free(so->so_tcpcb); + } free(so); } |