diff options
| author | Matheus Tavares Bernardino <quic_mathbern@quicinc.com> | 2023-10-29 14:50:31 +0000 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2023-10-31 14:10:21 +0000 |
| commit | 2eb71a0c20a6a77be128a76c1ef8fb5dc7028a8b (patch) | |
| tree | d11799da16112d010b973eead1a94cd626f91a3c /semihosting | |
| parent | dbd6623ce726878f4cbbad4a1af160fcd1d2fe7b (diff) | |
| download | qemu-2eb71a0c20a6a77be128a76c1ef8fb5dc7028a8b.zip qemu-2eb71a0c20a6a77be128a76c1ef8fb5dc7028a8b.tar.gz qemu-2eb71a0c20a6a77be128a76c1ef8fb5dc7028a8b.tar.bz2 | |
semihosting: fix memleak at semihosting_arg_fallback
We duplicate "cmd" as strtok may modify its argument, but we forgot
to free it later. Furthermore, add_semihosting_arg doesn't take
responsibility for this memory either (it strdup's the argument).
Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <03d81c56bfc3d08224e4106efca5949d8894cfa5.1697801632.git.quic_mathbern@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231029145033.592566-18-alex.bennee@linaro.org>
Diffstat (limited to 'semihosting')
| -rw-r--r-- | semihosting/config.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/semihosting/config.c b/semihosting/config.c index 249a377..56283b5 100644 --- a/semihosting/config.c +++ b/semihosting/config.c @@ -113,12 +113,13 @@ static int add_semihosting_arg(void *opaque, void semihosting_arg_fallback(const char *file, const char *cmd) { char *cmd_token; + g_autofree char *cmd_dup = g_strdup(cmd); /* argv[0] */ add_semihosting_arg(&semihosting, "arg", file, NULL); /* split -append and initialize argv[1..n] */ - cmd_token = strtok(g_strdup(cmd), " "); + cmd_token = strtok(cmd_dup, " "); while (cmd_token) { add_semihosting_arg(&semihosting, "arg", cmd_token, NULL); cmd_token = strtok(NULL, " "); |