aboutsummaryrefslogtreecommitdiff
path: root/scsi
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2021-03-09 14:56:42 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2021-03-16 14:30:30 -0400
commitdc293f60b02ff9a4d51ccae153b1685cc8a34d79 (patch)
tree59e53f66ee8cf12b8b83d61472e27dd8a5ef3f36 /scsi
parent26dbec410e9f5194767d17fd19cb64fc1f487e1b (diff)
downloadqemu-dc293f60b02ff9a4d51ccae153b1685cc8a34d79.zip
qemu-dc293f60b02ff9a4d51ccae153b1685cc8a34d79.tar.gz
qemu-dc293f60b02ff9a4d51ccae153b1685cc8a34d79.tar.bz2
scsi: fix sense code for EREMOTEIO
SENSE_CODE(LUN_COMM_FAILURE) has an ABORTED COMMAND sense key, so it results in a retry in Linux. To ensure that EREMOTEIO is forwarded to the guest, use a HARDWARE ERROR sense key instead. Note that the code before commit d7a84021d was incorrect because it used HARDWARE_ERROR as a SCSI status, not as a sense key. Reported-by: Marc-André Lureau <marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'scsi')
-rw-r--r--scsi/utils.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/scsi/utils.c b/scsi/utils.c
index 873e05a..357b036 100644
--- a/scsi/utils.c
+++ b/scsi/utils.c
@@ -589,7 +589,7 @@ int scsi_sense_from_errno(int errno_value, SCSISense *sense)
return TASK_SET_FULL;
#ifdef CONFIG_LINUX
/* These errno mapping are specific to Linux. For more information:
- * - scsi_decide_disposition in drivers/scsi/scsi_error.c
+ * - scsi_check_sense and scsi_decide_disposition in drivers/scsi/scsi_error.c
* - scsi_result_to_blk_status in drivers/scsi/scsi_lib.c
* - blk_errors[] in block/blk-core.c
*/
@@ -599,7 +599,7 @@ int scsi_sense_from_errno(int errno_value, SCSISense *sense)
*sense = SENSE_CODE(READ_ERROR);
return CHECK_CONDITION;
case EREMOTEIO:
- *sense = SENSE_CODE(LUN_COMM_FAILURE);
+ *sense = SENSE_CODE(TARGET_FAILURE);
return CHECK_CONDITION;
#endif
case ENOMEDIUM: