diff options
author | Daniel P. Berrangé <berrange@redhat.com> | 2024-01-08 17:13:55 +0000 |
---|---|---|
committer | Stefan Hajnoczi <stefanha@redhat.com> | 2024-03-12 14:52:07 -0400 |
commit | 081340d1ddfe27e80f653d707c278edf06a9a803 (patch) | |
tree | 7621050a37772d67a41c480ac74433e48ba3af3d /scripts | |
parent | 8f3f329f5e0117bd1a23a79ab751f8a7d3471e4b (diff) | |
download | qemu-081340d1ddfe27e80f653d707c278edf06a9a803.zip qemu-081340d1ddfe27e80f653d707c278edf06a9a803.tar.gz qemu-081340d1ddfe27e80f653d707c278edf06a9a803.tar.bz2 |
tracetool: remove redundant --target-type / --target-name args
The --target-type and --target-name args are used to construct
the default probe prefix if '--probe-prefix' is not given. The
meson.build will always pass '--probe-prefix', so the other args
are effectively redundant.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-id: 20240108171356.1037059-2-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/tracetool.py | 24 |
1 files changed, 5 insertions, 19 deletions
diff --git a/scripts/tracetool.py b/scripts/tracetool.py index ab7653a..5de9ce9 100755 --- a/scripts/tracetool.py +++ b/scripts/tracetool.py @@ -44,12 +44,9 @@ Options: --help This help message. --list-backends Print list of available backends. --check-backends Check if the given backend is valid. - --binary <path> Full path to QEMU binary. - --target-type <type> QEMU emulator target type ('system' or 'user'). - --target-name <name> QEMU emulator target name. - --group <name> Name of the event group - --probe-prefix <prefix> Prefix for dtrace probe names - (default: qemu-<target-type>-<target-name>).\ + --binary <path> Full path to QEMU binary (required for 'stap' backend). + --group <name> Name of the event group. + --probe-prefix <prefix> Prefix for dtrace probe names (required for 'stap' backend). """ % { "script" : _SCRIPT, "backends" : backend_descr, @@ -67,7 +64,7 @@ def main(args): long_opts = ["backends=", "format=", "help", "list-backends", "check-backends", "group="] - long_opts += ["binary=", "target-type=", "target-name=", "probe-prefix="] + long_opts += ["binary=", "probe-prefix="] try: opts, args = getopt.getopt(args[1:], "", long_opts) @@ -79,8 +76,6 @@ def main(args): arg_format = "" arg_group = None binary = None - target_type = None - target_name = None probe_prefix = None for opt, arg in opts: if opt == "--help": @@ -102,10 +97,6 @@ def main(args): elif opt == "--binary": binary = arg - elif opt == '--target-type': - target_type = arg - elif opt == '--target-name': - target_name = arg elif opt == '--probe-prefix': probe_prefix = arg @@ -127,13 +118,8 @@ def main(args): if arg_format == "stap": if binary is None: error_opt("--binary is required for SystemTAP tapset generator") - if probe_prefix is None and target_type is None: - error_opt("--target-type is required for SystemTAP tapset generator") - if probe_prefix is None and target_name is None: - error_opt("--target-name is required for SystemTAP tapset generator") - if probe_prefix is None: - probe_prefix = ".".join(["qemu", target_type, target_name]) + error_opt("--probe-prefix is required for SystemTAP tapset generator") if len(args) < 2: error_opt("missing trace-events and output filepaths") |