aboutsummaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2016-06-09 20:48:07 -0600
committerMarkus Armbruster <armbru@redhat.com>2016-06-30 15:24:36 +0200
commit01fb8e192d2cb139622df22983360836e39a64ff (patch)
tree67e817c5975cbe3d6263618c57861ab69d239f8f /scripts
parentff5394ad5b1039efef9844f5844f952aec93ef37 (diff)
downloadqemu-01fb8e192d2cb139622df22983360836e39a64ff.zip
qemu-01fb8e192d2cb139622df22983360836e39a64ff.tar.gz
qemu-01fb8e192d2cb139622df22983360836e39a64ff.tar.bz2
checkpatch: There is no qemu_strtod()
Maybe there should be; but until there is, we should not flag strtod() calls as something to replaced with qemu_strtod(). We also lack qemu_strtof() and qemu_strtold(), but as no one has been using strtof() or strtold(), it's not worth complicating the regex for them. (Ironically, I had to use 'git commit -n' since checkpatch uses TAB indents, in violation of its own recommendations.) Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <1465526889-8339-3-git-send-email-eblake@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'scripts')
-rwxr-xr-xscripts/checkpatch.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c939a32..cf32c8f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2453,7 +2453,7 @@ sub process {
}
# recommend qemu_strto* over strto* for numeric conversions
- if ($line =~ /\b(strto[^k].*?)\s*\(/) {
+ if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
WARN("consider using qemu_$1 in preference to $1\n" . $herecurr);
}
# check for module_init(), use category-specific init macros explicitly please