diff options
| author | Laurent Vivier <lvivier@redhat.com> | 2021-11-18 14:32:23 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2021-11-28 17:03:52 -0500 |
| commit | 9323f892b39d133eb69b301484bf7b2f3f49737d (patch) | |
| tree | a816dfce6519fbccb73b5e04fcb4e2165d23fbff /scripts/signrom.py | |
| parent | 7abba7c638ab809e626f379617cb8590a733eabf (diff) | |
| download | qemu-9323f892b39d133eb69b301484bf7b2f3f49737d.zip qemu-9323f892b39d133eb69b301484bf7b2f3f49737d.tar.gz qemu-9323f892b39d133eb69b301484bf7b2f3f49737d.tar.bz2 | |
failover: fix unplug pending detection
Failover needs to detect the end of the PCI unplug to start migration
after the VFIO card has been unplugged.
To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in
pcie_unplug_device().
But since
17858a169508 ("hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35")
we have switched to ACPI unplug and these functions are not called anymore
and the flag not set. So failover migration is not able to detect if card
is really unplugged and acts as it's done as soon as it's started. So it
doesn't wait the end of the unplug to start the migration. We don't see any
problem when we test that because ACPI unplug is faster than PCIe native
hotplug and when the migration really starts the unplug operation is
already done.
See c000a9bd06ea ("pci: mark device having guest unplug request pending")
a99c4da9fc2a ("pci: mark devices partially unplugged")
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Ani Sinha <ani@anisinha.ca>
Message-Id: <20211118133225.324937-4-lvivier@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'scripts/signrom.py')
0 files changed, 0 insertions, 0 deletions