aboutsummaryrefslogtreecommitdiff
path: root/scripts/qapi/introspect.py
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2018-06-20 14:47:42 +0200
committerMarkus Armbruster <armbru@redhat.com>2018-06-22 16:33:47 +0200
commitda112e83c188ebe0fe5946c78ae7793341c93955 (patch)
treefb713e8ef147797503339bdbdacb7b085a25cba0 /scripts/qapi/introspect.py
parent0d6b93deeeb3cc190692d629f5927befdc8b1fb8 (diff)
downloadqemu-da112e83c188ebe0fe5946c78ae7793341c93955.zip
qemu-da112e83c188ebe0fe5946c78ae7793341c93955.tar.gz
qemu-da112e83c188ebe0fe5946c78ae7793341c93955.tar.bz2
qapi/introspect: Eliminate pointless variable in .visit_end()
Commit 1a9a507b2e3 "qapi-introspect: Hide type names" added local variable @jsons to improve sorting, but also removed the sorting. It was part of a big series that went to v8, and it made sense until v2 or so... Commit 7d0f982bfbb replaced @jsons by @qlits, preserving the uselessness. Get rid of it. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20180620124742.16979-1-armbru@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Diffstat (limited to 'scripts/qapi/introspect.py')
-rw-r--r--scripts/qapi/introspect.py5
1 files changed, 1 insertions, 4 deletions
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index 5b6c72c..6ad198a 100644
--- a/scripts/qapi/introspect.py
+++ b/scripts/qapi/introspect.py
@@ -75,13 +75,10 @@ class QAPISchemaGenIntrospectVisitor(QAPISchemaMonolithicCVisitor):
def visit_end(self):
# visit the types that are actually used
- qlits = self._qlits
- self._qlits = []
for typ in self._used_types:
typ.visit(self)
# generate C
# TODO can generate awfully long lines
- qlits.extend(self._qlits)
name = c_name(self._prefix, protect=False) + 'qmp_schema_qlit'
self._genh.add(mcgen('''
#include "qapi/qmp/qlit.h"
@@ -93,7 +90,7 @@ extern const QLitObject %(c_name)s;
const QLitObject %(c_name)s = %(c_string)s;
''',
c_name=c_name(name),
- c_string=to_qlit(qlits)))
+ c_string=to_qlit(self._qlits)))
self._schema = None
self._qlits = []
self._used_types = []